Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

This avoids accidental introduction (such as in #97488) of executable files into the root directory, not just under library/, src/ or compiler/.

Resolves #98792

This avoids accidental introduction (such as in rust-lang#97488).
@rust-highfive
Copy link
Contributor

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2022
@ghost
Copy link

ghost commented Jul 2, 2022

Also accidentally added a bin file once 😅

Useful! :)

@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jul 4, 2022
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with the nit fixed - I agree git ls-files would be nice, but this is definitely better than the status quo.

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 4, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 4, 2022

📌 Commit 45b87fb has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 4, 2022
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#98738 (Clarify MIR semantics of checked binary operations)
 - rust-lang#98782 (Improve spans for specialization error)
 - rust-lang#98793 (Lint against executable files in the root directory)
 - rust-lang#98814 (rustdoc: Censor certain complex unevaluated const exprs)
 - rust-lang#98878 (add more `rustc_pass_by_value`)
 - rust-lang#98879 (Fix "wrap closure in parenthesis" suggestion for `async` closure)
 - rust-lang#98886 (incr.comp.: Make split-dwarf commandline options [TRACKED].)
 - rust-lang#98898 (Add "no-div-regex" eslint rule)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2a40911 into rust-lang:master Jul 5, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

./x.py test tidy should reject additions of new binary files
5 participants